feat: added a check for gc code to run #3419
Conversation
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
JustinRush80
changed the title
| let generated_col_expressions = this | ||
| .snapshot | ||
| .as_ref() | ||
| .map(|v| v.schema().get_generated_columns().unwrap_or_default()) | ||
| .unwrap_or_default(); |
There was a problem hiding this comment.
You can do snapshot.schema() now since you already checked existence :)
There was a problem hiding this comment.
Ahh thank you for the catch!
| let (source, missing_generated_columns) = | ||
| add_missing_generated_columns(source.clone(), &generated_col_expressions)?; | ||
|
|
||
| source_with_gc = Some(source); |
There was a problem hiding this comment.
small nit, but we can do same as you did in the write mod, just use a mut source
|
@JustinRush80 is it ready? |
Yes I believe so should I be concerned about the failed coverage check? |
JustinRush80
requested review from
wjones127,
roeap,
rtyler and
hntd187
as code owners
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
No it got broken since we added the |
JustinRush80
force-pushed
the
fix/valid_gc
branch
3 times, most recently
from
d3ff34b to
dac4a70
Compare
Signed-off-by: JustinRush80 <[email protected]>
Head branch was pushed to by a user without write access
JustinRush80
force-pushed
the
fix/valid_gc
branch
from
dac4a70 to
4ecc06c
Compare
Description
Add a validation check that only runs if generated columns feature is enabled in the tablefeatures or writer version 5 is enabled
Related Issue(s)
Documentation